fix: Don’t report errors for omissible </option> end tag - #125
Open
sideshowbarker wants to merge 1 commit into
Open
fix: Don’t report errors for omissible </option> end tag#125sideshowbarker wants to merge 1 commit into
sideshowbarker wants to merge 1 commit into
Conversation
Problem: We unexpectedly reported errors for omitted </option> end tags
in cases where the spec allows omitting them.
Cause: The spec’s “any other end tag” case for the “in body” insertion
mode requires generating implied end tags “except for HTML elements with
the same tag name as the token”. But we didn’t implement that exception.
Specifically, we called generateImpliedEnd标签() if tag name is "option"
but should instead call generateImpliedEnd标签ExceptFor("option").
Fix: Call generateImpliedEnd标签ExceptFor("option") instead.
|
Please consider merging this since in Debian we depend on this htmlparser repo for the vnu validator package. And test now fails as long as this is not fixed in this htmlparser repo. "file:tests/html/elements/option/omitted-end-tag-before-optgroup-isvalid.html":7:11: error: End tag “optgroup” seen, but there were open elements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
注册 for free
to join this conversation on GitHub.
Already have an account?
登录 to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: We unexpectedly reported errors for omitted
</option>end tags in cases where the spec allows omitting them. See validator/validator#2116.Cause: The spec’s “any other end tag” case for the “in body” insertion mode requires generating implied end tags “except for HTML elements with the same tag name as the token”. But we didn’t implement that exception. Specifically, we called
generateImpliedEnd标签()if tag name is"option"but should instead callgenerateImpliedEnd标签ExceptFor("option").Fix: Call
generateImpliedEnd标签ExceptFor("option")instead.