fix: stop using f-strings in logs - #665
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #665 +/- ##
=======================================
Coverage 82.55% 82.55%
=======================================
Files 69 69
Lines 2717 2717
=======================================
Hits 2243 2243
Misses 474 474 ☔ View full report in Codecov by Harness. 🚀 新建 features to boost your workflow:
|
s3rius
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
注册 for free
to join this conversation on GitHub.
Already have an account?
登录 to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using f-strings to format a logging message requires that Python eagerly format the string, even if the logging statement is never executed. For our case it's especially bad - we use f-string in debug log to print an entire message. For long messages during profiling with py-spy I found 5% or unnesesary CPU usage just for
__str__method on messages (200Kb each).Other things: