feat: add C implementation for stats/base/dists/studentized-range/quantile - #14768
Draft
Planeshifter wants to merge 1 commit into
Draft
feat: add C implementation for stats/base/dists/studentized-range/quantile#14768Planeshifter wants to merge 1 commit into
stats/base/dists/studentized-range/quantile#14768Planeshifter wants to merge 1 commit into
Conversation
…antile` - Add src/main.c with the quantile algorithm ported from JS: apnorminv (inverse normal), qtrngo (initial estimate), and secant-method root-finding iterating the CDF - Link to the CDF C library instead of inlining the CDF code - Add public header, native addon, build configuration - Add manifest.json with CDF dependency - Add native benchmark, native test, C benchmark, C example - Add README C API documentation section - Update package.json with gypfile and native directories - Update lib/index.js with tryRequire pattern for native addon Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Planeshifter
force-pushed
the
philipp/studentized-range-quantile-c
branch
from
August 29, 2026 06:18
995157b to
89cb5e4
比较
Member
Author
|
An automated check found potentially unrelated issue/PR references in this PR:
Why this matters: GitHub automatically closes issues referenced with What to do:
This assessment was generated by an AI model and is informational only. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
注册 for free
to join this conversation on GitHub.
Already have an account?
登录 to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #10107.
Description
This pull request:
@stdlib/stats/base/dists/studentized-range/quantileapnorminv(inverse normal approximation) andqtrngo(initial estimate) routines from JS to C@stdlib/stats/base/dists/studentized-range/cdf) rather than inlining the CDF codeRelated 问题
This pull request has the following related issues:
stats/base/dists/studentized-range/cdf#10106 (CDF C implementation, required dependency)Questions
No.
Other
This PR depends on #10106 (the CDF C implementation) being merged first, since the quantile links to the CDF C library via
manifest.jsondependencies.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code (Fable 5). The C implementation was ported from the existing JavaScript implementation, with manual review of numerical coefficients, convergence behavior, and edge cases.
@stdlib-js/reviewers