Skip to content

Update constructor to accept nullable Colors parameter - #37

Merged
splitbrain merged 1 commit into
splitbrain:masterfrom
SMillerDev:patch-1
Oct 28, 2025
Merged

Update constructor to accept nullable Colors parameter#37
splitbrain merged 1 commit into
splitbrain:masterfrom
SMillerDev:patch-1

Conversation

@SMillerDev

Copy link
Copy Markdown
Contributor

This will resolve issues in PHP 8.4 like the following

PHP Deprecated:  splitbrain\phpcli\Options::__construct(): Implicitly marking parameter $colors as nullable is deprecated, the explicit nullable type must be used instead in phpdraft/vendor/splitbrain/php-cli/src/Options.php on line 43

@splitbrain
splitbrain merged commit 813410b into splitbrain:master Oct 28, 2025
8 checks passed
@SMillerDev

Copy link
Copy Markdown
Contributor Author

Thanks for merging it so quickly. I found a couple more after this so I'll make a PR for those later

注册 for free to join this conversation on GitHub. Already have an account? 登录 to comment

标签

None yet

项目

None yet

Development

Successfully merging this pull request may close these issues.

2 participants