Port Old Bash to 新建 Go CI Tool - #23540
Open
kalverra wants to merge 1 commit into
Open
Conversation
product-security-plaid-production
Bot
requested review from
Tofel,
bolekk,
skudasov and
vyzaldysanchez
August 25, 2026 20:04
Contributor
|
✅ No conflicts with other open PRs targeting |
Tofel
reviewed
Aug 26, 2026
| "#wip", | ||
| "#bugfix", | ||
| "#internal", | ||
| } |
Contributor
There was a problem hiding this comment.
do we need some mechanism to validate/expand this list automatically, when what release process expects changes?
Collaborator
There was a problem hiding this comment.
The tags list was previously stored in the shell script, so I think this is a lateral move at-worst.
Tofel
reviewed
Aug 26, 2026
| assert.Contains(t, string(ghContent), "found_tags=#bugfix\n") | ||
| } | ||
|
|
||
| func TestChangesetCheck标签_ParityWithBash(t *testing.T) { |
Contributor
There was a problem hiding this comment.
nit: ParityWithBash won't mean much anymore once we've merged this PR, consider renaming?
Tofel
reviewed
Aug 26, 2026
| assert.Contains(t, string(ghContent), "resolved_image=123456789012.dkr.ecr.us-west-2.amazonaws.com/chainlink-integration-tests:v2.1.0") | ||
| } | ||
|
|
||
| func TestImageResolve_ParityWithBash(t *testing.T) { |
Contributor
There was a problem hiding this comment.
nit: ParityWithBash won't mean much anymore once we've merged this PR, consider renaming?
kalverra
force-pushed
the
DX-5065/go-ci-tool-first-ports
branch
2 times, most recently
from
August 26, 2026 17:29
facea06 to
89920d2
比较
kalverra
force-pushed
the
DX-5065/go-ci-tool-first-ports
branch
from
August 26, 2026 18:22
89920d2 to
8639ad2
比较
kalverra
force-pushed
the
DX-5065/go-ci-tool-first-ports
branch
from
August 26, 2026 18:49
8639ad2 to
a04336e
比较
kalverra
force-pushed
the
DX-5065/go-ci-tool-first-ports
branch
2 times, most recently
from
August 26, 2026 20:07
7ddd53d to
cd7898b
比较
kalverra
force-pushed
the
DX-5065/go-ci-tool-first-ports
branch
from
August 27, 2026 17:59
cd7898b to
1a26b6b
比较
kalverra
force-pushed
the
DX-5065/go-ci-tool-first-ports
branch
from
August 27, 2026 18:22
1a26b6b to
036d4b7
比较
|
erikburt
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
注册 for free
to join this conversation on GitHub.
Already have an account?
登录 to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Port a few low-risk bash scripts over to the new Go CI tool to prove the concept and make sure everything works well.
Stack created with GitHub Stacks CLI • Give Feedback 💬