Skip to content

Generalise (most) impls on Box - #161946

Open
nia-e wants to merge 1 commit into
rust-lang:mainfrom
nia-e:more-box-impls
Open

Generalise (most) impls on Box#161946
nia-e wants to merge 1 commit into
rust-lang:mainfrom
nia-e:more-box-impls

Conversation

@nia-e

@nia-e nia-e commented Aug 28, 2026

Copy link
Copy Markdown
Member

Resolves the trait impl concern for #156882; Default wasn't touched since changing that would be breaking, but hopefully all of this should be fine - I'll do a crater run to be sure. Certain impls that were for one reason or another Annoying to generalise (e.g. Clone for Box<Path>) were also untouched since I believe we can add those in the future, as they're on concrete types.

r? clarfonthey

@rustbot rustbot added O-solid Operating System: SOLID O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 28, 2026
@nia-e

nia-e commented Aug 28, 2026

Copy link
Copy Markdown
Member Author

also should do a perf run since monomorphisation.

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Aug 28, 2026
Generalise (most) impls on `Box`
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 28, 2026
@nia-e nia-e added A-allocators Area: Custom and system allocators S-waiting-on-perf Status: Waiting on a perf run to be completed. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2026
@clarfonthey

Copy link
Copy Markdown
Contributor

r=me pending crater + perf

@rust-bors

rust-bors Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 0c3b2c2 (0c3b2c226322b623e493b7611e4909ee6bc6a48d)
Base parent: 344f790 (344f7902949345394fa40a5d7dda31f012ccbc0d)

@rust-timer

This comment has been minimized.

@nia-e

nia-e commented Aug 28, 2026

Copy link
Copy Markdown
Member Author

@craterbot check

@craterbot

Copy link
Copy Markdown
Collaborator

👌 Experiment pr-161946 created and queued.
🤖 Automatically detected try build 0c3b2c2
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Aug 28, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (0c3b2c2): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.4% [0.4%, 0.4%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.5% [-0.5%, -0.5%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 3.2%, secondary -0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
9.0% [9.0%, 9.0%] 1
Regressions ❌
(secondary)
4.1% [1.6%, 8.7%] 5
Improvements ✅
(primary)
-2.6% [-2.6%, -2.6%] 1
Improvements ✅
(secondary)
-4.6% [-5.7%, -2.4%] 5
All ❌✅ (primary) 3.2% [-2.6%, 9.0%] 2

Cycles

Results (primary 2.7%, secondary -11.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.7% [2.7%, 2.7%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-11.8% [-20.6%, -3.9%] 7
All ❌✅ (primary) 2.7% [2.7%, 2.7%] 1

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 475.673s -> 475.454s (-0.05%)
Artifact size: 403.60 MiB -> 402.86 MiB (-0.18%)

@nia-e

nia-e commented Aug 28, 2026

Copy link
Copy Markdown
Member Author

that's a nothingburger, nice. time to just wait a zillion years for crater lol

注册 for free to join this conversation on GitHub. Already have an account? 登录 to comment

标签

A-allocators Area: Custom and system allocators O-solid Operating System: SOLID O-windows Operating system: Windows S-waiting-on-crater Status: Waiting on a crater run to be completed. T-libs Relevant to the library team, which will review and decide on the PR/issue.

项目

None yet

Development

Successfully merging this pull request may close these issues.

5 participants