Skip to content

Apply rubocop and enable in CI - #387

Open
Nuzair46 wants to merge 3 commits into
drop-support-for-eol-corefrom
improve-rubocop
Open

Apply rubocop and enable in CI#387
Nuzair46 wants to merge 3 commits into
drop-support-for-eol-corefrom
improve-rubocop

Conversation

@Nuzair46

Copy link
Copy Markdown
Member

This PR applies rubocop rules (mostly auto fixes) and enables rubocop check in the CI

Comment thread lib/config/options.rb
marshal_dump.each(*args, &block)
end

def each_key(*args, &block)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this new method for a more hash like Config

return {} if @env.nil? || @env.empty?

hash = Hash.new
hash = {}

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there are no defaults set here, we can just use literal

@Nuzair46
Nuzair46 marked this pull request as ready for review January 28, 2026 13:42
注册 for free to join this conversation on GitHub. Already have an account? 登录 to comment

标签

None yet

Development

Successfully merging this pull request may close these issues.

1 participant