Add VirtualColumn and VirtualRow docs - #4845
Open
lunaleaps wants to merge 3 commits into
Open
Conversation
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
||
| ### Item Rendering | ||
|
|
||
| `VirtualColumn` expects an immutable `VirtualCollection` of items and an `itemsToKey` function. |
Contributor
There was a problem hiding this comment.
Suggested change
| `VirtualColumn` expects an immutable `VirtualCollection` of items and an `itemsToKey` function. | |
| `VirtualColumn` expects an immutable `VirtualCollection` of items and an `itemToKey` function. |
Contributor
There was a problem hiding this comment.
This doc sometimes uses both itemsToKey and itemToKey, I assume that only one is correct.
|
|
||
| `VirtualColumn` expects an immutable `VirtualCollection` of items and an `itemsToKey` function. | ||
|
|
||
| When `VirtualColumn` renders an item, it calls the `children` render function once and memoizes the result. If an item changes, a new item should be provided with the same key. Items with identical keys, as returned by `itemsToKey`, will update the same React element. |
Contributor
|
@lunaleaps do we need it in the 0.83 release? |
atlj
reviewed
Dec 12, 2025
| <ScrollView> | ||
| <VirtualColumn | ||
| items={new VirtualArray(items)}> | ||
| {(item, key) => <Text>{item.value}</Text>} |
There was a problem hiding this comment.
key is not used here, is it deliberate?
Suggested change
| {(item, key) => <Text>{item.value}</Text>} | |
| {(item, key) => <Text key={key}>{item.value}</Text>} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
注册 for free
to join this conversation on GitHub.
Already have an account?
登录 to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add VirtualColumn and VirtualRow docs
See VirtualColumn docs
See VirtualRow docs