Add zizmor checks for GitHub 操作 - #16314
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
AlexWaygood
marked this pull request as ready for review
August 28, 2026 14:29
AlexWaygood
commented
Aug 28, 2026
This comment has been minimized.
This comment has been minimized.
JelleZijlstra
approved these changes
Aug 29, 2026
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
mxr
reviewed
Aug 29, 2026
| - repo: https://github.com/zizmorcore/zizmor-pre-commit | ||
| rev: 451b56af716f9f0d0c2b816503a3fd0cf8b036fa # frozen: v1.29.0 | ||
| hooks: | ||
| - id: zizmor |
Contributor
There was a problem hiding this comment.
Suggested change
| - id: zizmor | |
| - id: zizmor | |
| args: [--no-progress, --fix] |
Would you consider these hook args in order to autofix issues when they come up?
Member
Author
There was a problem hiding this comment.
Yes I would! Want to make a PR? Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
注册 for free
to join this conversation on GitHub.
Already have an account?
登录 to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add zizmor security checks for GitHub 操作 and address their findings by restricting credentials and permissions, safely passing the base ref to Bash, and documenting the required
workflow_runtrigger.Stacked on #16313.
Assisted by Codex.