gh-156517: Clarify that site.getsitepackages() doesn't check for existance - #156524
Open
StanFromIreland wants to merge 3 commits into
Open
gh-156517: Clarify that site.getsitepackages() doesn't check for existance#156524StanFromIreland wants to merge 3 commits into
site.getsitepackages() doesn't check for existance#156524StanFromIreland wants to merge 3 commits into
Conversation
sys.getsitepackages() doesn't check for existancesite.getsitepackages() doesn't check for existance
Documentation build overview
|
mbyrnepr2
reviewed
Aug 28, 2026
mbyrnepr2
left a comment
Contributor
There was a problem hiding this comment.
Thanks @StanFromIreland for picking it up. I was definitely misusing the function (although that is probably more a reflection on me :D).
I've made some suggestions but if you prefer to keep things as you had it then please feel free; they are just suggestions and I don't mind either way.
Thanks again!
warsaw
approved these changes
Aug 28, 2026
warsaw
left a comment
Member
There was a problem hiding this comment.
Approved, with some additional feedback.
Co-authored-by: Barry Warsaw <barry@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
注册 for free
to join this conversation on GitHub.
Already have an account?
登录 to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
site.getsitepackagesfunction returns a non-existent path (depending on theprefixesvalue). #156517