Skip to content

gh-156466: fix cleanup on error after Enter in codegen_enter_scope - #156467

Merged
iritkatriel merged 2 commits into
python:mainfrom
iritkatriel:gh-156466-1
Aug 29, 2026
Merged

gh-156466: fix cleanup on error after Enter in codegen_enter_scope#156467
iritkatriel merged 2 commits into
python:mainfrom
iritkatriel:gh-156466-1

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Aug 27, 2026

Copy link
Copy Markdown
Member

If codegen_enter_scope errors after _PyCompile_EnterScope, it should exit the scope before returning ERROR.

@iritkatriel iritkatriel added 3.14 bugs and security fixes 3.15 pre-release feature fixes, bugs and security fixes 3.16 new features, bugs and security fixes skip news labels Aug 27, 2026
@picnixz picnixz added needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes and removed 3.14 bugs and security fixes 3.15 pre-release feature fixes, bugs and security fixes 3.16 new features, bugs and security fixes labels Aug 27, 2026
Comment thread Python/codegen.c
@iritkatriel
iritkatriel merged commit 41b3f0a into python:main Aug 29, 2026
51 checks passed
@miss-islington-app

Copy link
Copy Markdown

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Sorry, @iritkatriel, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 41b3f0af266b408438cab36625c6ad71040d38e5 3.14

@bedevere-app

bedevere-app Bot commented Aug 29, 2026

Copy link
Copy Markdown

GH-156616 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Aug 29, 2026
@bedevere-app

bedevere-app Bot commented Aug 29, 2026

Copy link
Copy Markdown

GH-156617 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Aug 29, 2026
注册 for free to join this conversation on GitHub. Already have an account? 登录 to comment

项目

None yet

Development

Successfully merging this pull request may close these issues.

3 participants