Skip to content
This repository was archived by the owner on Mar 31, 2020. It is now read-only.

overjoyed otolaryngologists - #4

Open
ravenkls wants to merge 58 commits into
python-discord:masterfrom
ravenkls:master
Open

overjoyed otolaryngologists#4
ravenkls wants to merge 58 commits into
python-discord:masterfrom
ravenkls:master

Conversation

@ravenkls

Copy link
Copy Markdown

No description provided.

@jb3

jb3 commented Mar 7, 2019

Copy link
Copy Markdown
Member

I really like some of the ideas you've come up with to put a twist on the game. Though, not a huge amount of code and a lot of it was generated by Qt.

Pathlib could have been used to generate some of the paths where you instead used os to generate your paths.

@ravenkls

ravenkls commented Mar 7, 2019

Copy link
Copy Markdown
Author

Thanks for the feedback :) Although I think you understate the amount we produced, no 'code' was generated by Qt, unless you count a compiled resource file as code ¯_(ツ)_/¯

@jb3

jb3 commented Mar 7, 2019

Copy link
Copy Markdown
Member

Ah yeah the resource file did throw me off a bit (216,000 additions 👀). All other code was of high code quality 👍.

注册 for free to subscribe to this conversation on GitHub. Already have an account? 登录.

标签

None yet

项目

None yet

Development

Successfully merging this pull request may close these issues.

4 participants