Reduce Sol/Sierpinski public frequency to 1, remove Labyrinth - #5131
Reduce Sol/Sierpinski public frequency to 1, remove Labyrinth#5131evanpelle wants to merge 1 commit into
Conversation
Sol 20 -> 1, Sierpinski 10 -> 1, Labyrinth 6 -> 0 in the map info.json, manifest.json, and generated Maps.gen.ts. Labyrinth is added to the frequency exemptions in MapConsistency.test.ts. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: 组织 UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
Included review availability: Your plan provides up to 8 included reviews per hour; 3 remain after this review. WalkthroughThe change updates multiplayer frequencies for Labyrinth, Sierpinski, and Sol in map data, manifests, and generated runtime data. The consistency test now allows Labyrinth to use frequency ChangesMap multiplayer frequency updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This PR only changes public map rotation frequencies and keeps the corresponding map metadata synchronized, so no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. (6 skipped: 6 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🤖 Claude Code ReviewVerdict: ✅ No issues found — 0 critical, 0 major, 0 minor. This PR makes a small, mechanical, data-only change: it lowers Checked and confirmed:
No comments to post inline. |
Summary
multiplayer_frequencyfor Sol from 20 → 1 and Sierpinski from 10 → 1 so they appear far less often in public FFA/team/special playlists.multiplayer_frequencyto 0, removing it from public rotations entirely (still selectable in singleplayer and private lobbies), following the Luna precedent in Remove Luna from public map rotations #5123.map-generator/assets/maps/<map>/info.json,resources/maps/<map>/manifest.json, and the generatedsrc/core/game/Maps.gen.ts(Go isn't available locally to runnpm run gen-maps; the output is identical).FREQUENCY_EXEMPTIONSintests/MapConsistency.test.tssince it now has a zero frequency.Test plan
npx vitest tests/MapConsistency.test.ts tests/server/MapPlaylistOvertime.test.ts --run— 18/18 passnpx tsc --noEmit— cleannpx prettier --checkon all changed files — clean🤖 Generated with Claude Code