Skip to content

Reduce Sol/Sierpinski public frequency to 1, remove Labyrinth - #5131

Open
evanpelle wants to merge 1 commit into
mainfrom
t3code/reduce-public-sol-frequency
Open

Reduce Sol/Sierpinski public frequency to 1, remove Labyrinth#5131
evanpelle wants to merge 1 commit into
mainfrom
t3code/reduce-public-sol-frequency

Conversation

@evanpelle

Copy link
Copy Markdown
Collaborator

Summary

  • Set multiplayer_frequency for Sol from 20 → 1 and Sierpinski from 10 → 1 so they appear far less often in public FFA/team/special playlists.
  • Set Labyrinth's multiplayer_frequency to 0, removing it from public rotations entirely (still selectable in singleplayer and private lobbies), following the Luna precedent in Remove Luna from public map rotations #5123.
  • Each value is mirrored across map-generator/assets/maps/<map>/info.json, resources/maps/<map>/manifest.json, and the generated src/core/game/Maps.gen.ts (Go isn't available locally to run npm run gen-maps; the output is identical).
  • Added Labyrinth to FREQUENCY_EXEMPTIONS in tests/MapConsistency.test.ts since it now has a zero frequency.

Test plan

  • npx vitest tests/MapConsistency.test.ts tests/server/MapPlaylistOvertime.test.ts --run — 18/18 pass
  • npx tsc --noEmit — clean
  • npx prettier --check on all changed files — clean

🤖 Generated with Claude Code

Sol 20 -> 1, Sierpinski 10 -> 1, Labyrinth 6 -> 0 in the map info.json,
manifest.json, and generated Maps.gen.ts. Labyrinth is added to the
frequency exemptions in MapConsistency.test.ts.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: 组织 UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 38b95c7a-e665-4e5d-b3c6-ebaa7dfc5bcb

📥 提交

Reviewing files that changed from the base of the PR and between 48faa40 and 50f13d5.

📒 Files selected for processing (8)
  • map-generator/assets/maps/labyrinth/info.json
  • map-generator/assets/maps/sierpinski/info.json
  • map-generator/assets/maps/sol/info.json
  • resources/maps/labyrinth/manifest.json
  • resources/maps/sierpinski/manifest.json
  • resources/maps/sol/manifest.json
  • src/core/game/Maps.gen.ts
  • tests/MapConsistency.test.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 3 remain after this review.


Walkthrough

The change updates multiplayer frequencies for Labyrinth, Sierpinski, and Sol in map data, manifests, and generated runtime data. The consistency test now allows Labyrinth to use frequency 0.

Changes

Map multiplayer frequency updates

Layer / File(s) Summary
Update map frequency configurations
map-generator/assets/maps/*/info.json, resources/maps/*/manifest.json
Labyrinth changes from 6 to 0. Sierpinski changes from 10 to 1. Sol changes from 20 to 1.
Sync runtime data and consistency rules
src/core/game/Maps.gen.ts, tests/MapConsistency.test.ts
Generated map data uses the updated frequencies. The consistency test exempts Labyrinth from the positive-frequency requirement.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 50f13

This PR only changes public map rotation frequencies and keeps the corresponding map metadata synchronized, so no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: rickd004

Poem

Three maps adjust their multiplayer tide
Labyrinth rests, while two maps glide
Generated values follow the chart
A test keeps the rules in part
Small numbers guide the maps’ next start

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description accurately explains the frequency changes, mirrored files, test updates, and validation results.
Title check ✅ Passed The title clearly summarizes the main changes: reducing Sol and Sierpinski frequency and removing Labyrinth from public rotation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked 问题 check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. (6 skipped: 6 unsupported.)

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

🤖 Claude Code Review

Verdict: ✅ No issues found — 0 critical, 0 major, 0 minor.

This PR makes a small, mechanical, data-only change: it lowers multiplayer_frequency for Sol (20→1) and Sierpinski (10→1), zeroes it out for Labyrinth, and mirrors each value identically across map-generator/assets/maps/<map>/info.json, resources/maps/<map>/manifest.json, and the generated src/core/game/Maps.gen.ts, plus adds Labyrinth to FREQUENCY_EXEMPTIONS in tests/MapConsistency.test.ts.

Checked and confirmed:

  • All three mirrored files agree on the new values for each of the three maps (Sol, Sierpinski, Labyrinth) — no drift between info.json, manifest.json, and Maps.gen.ts.
  • No unrelated fields (nations, categories, themes, customTribes) were disturbed in any of the touched files.
  • tests/MapConsistency.test.ts's "positive multiplayer_frequency" check compares info.multiplayer_frequency ?? 0 against map.multiplayerFrequency with strict equality, so Labyrinth's 0 in all three files is internally consistent and the FREQUENCY_EXEMPTIONS addition is required and correctly placed (matches the existing Luna zero-frequency precedent).
  • No CLAUDE.md violations: the only src/core file touched (Maps.gen.ts) is a purely numeric, non-logic edit accompanied by a test update; no floating-point/determinism concerns; no user-visible text was added, so the translateText()/en.json i18n rule doesn't apply.

No comments to post inline.

注册 for free to join this conversation on GitHub. Already have an account? 登录 to comment

标签

None yet

项目

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant