fs: add openAsBlobSync - #65644
Open
greenheadHQ wants to merge 1 commit into
Open
Conversation
Signed-off-by: greenhead <greenheadhq@gmail.com> Assisted-by: Codex
Collaborator
|
Review requested:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
注册 for free
to join this conversation on GitHub.
Already have an account?
登录 to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
fs.openAsBlobSync(path[, options])as a synchronous counterpart tofs.openAsBlob(). For real-file paths, it returns the existing file-backedBlobdirectly while leaving the Promise-returning API unchanged; reading the Blob's contents remains lazy and asynchronous.This follows up on #65462. 比较d with #49759, the change is additive: it does not modify
fs.openAsBlob()or add anfs.promisesalias.Documentation is included. Tests cover supported path types and validation, file mutation detection, Permission Model denial, VFS mount ownership, and verify that
fs.openAsBlob()still returns a Promise.Disclosure: I used codex for research and some implementation work. I reviewed and thoroughly tested the changes myself.
Refs: #65462
Refs: #49759