docs: clarify setImmediate and setTimeout ordering - #132
Open
ojedaJD wants to merge 1 commit into
Open
Conversation
Clarify the execution order of setTimeout and setImmediate when scheduled from the main module and inside an I/O callback. Signed-off-by: JD De Dios Ojeda <89946133+ojedaJD@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/timers Please review the changes when you have a chance. Thank you! 🙏 |
ovflowd
requested changes
Aug 30, 2026
ovflowd
left a comment
Member
There was a problem hiding this comment.
The text is kinda incorrect. We don't really need changes on this. We often enough get PRs for this specific line, but it doesn't need a change :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
注册 for free
to join this conversation on GitHub.
Already have an account?
登录 to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #24.
Ports the
setImmediate()andsetTimeout()ordering clarification from nodejs/nodejs.org#8623.