Skip to content

fix(AppMenu操作): Shorten "More actions" label - #63751

Open
kra-mo wants to merge 1 commit into
masterfrom
fix/app-menu-more-label
Open

fix(AppMenu操作): Shorten "More actions" label#63751
kra-mo wants to merge 1 commit into
masterfrom
fix/app-menu-more-label

Conversation

@kra-mo

@kra-mo kra-mo commented Aug 28, 2026

Copy link
Copy Markdown
Member

Partly to avoid awkward wrapping

关注-up to #63134

cc @susnux

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Partly to avoid awkward wrapping

Signed-off-by: kramo <git@kramo.page>
@kra-mo kra-mo added this to the Nextcloud 35 milestone Aug 28, 2026
@kra-mo
kra-mo requested a review from a team as a code owner August 28, 2026 07:50
@kra-mo kra-mo added the design Design, UI, UX, etc. label Aug 28, 2026
@kra-mo
kra-mo requested review from kristian-zendato, skjnldsv and sorbaugh and removed request for a team August 28, 2026 07:50
@kra-mo kra-mo added 3. to review Waiting for reviews papercut Annoying recurring UX issue with possibly simple fix. labels Aug 28, 2026
@kra-mo
kra-mo requested a review from susnux August 28, 2026 07:50
@AndyScherzinger

Copy link
Copy Markdown
Member

/backport to stable35

@susnux susnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah thanks, so I can also cross this off my backlog :)

@joshtrichards joshtrichards left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker, but maybe keep "More" as the visible label while preserving "More actions" as the accessible label for the trigger and submenu? This follows the existing pattern where compact text has a more descriptive aria-label, such as "Back" being labeled "Back to login form" in Login.vue:

:aria-label="t('core', 'Back to login form')"

@susnux

susnux commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Not a blocker, but maybe keep "More" as the visible label while preserving "More actions" as the accessible

Thats more of an anti-pattern, visual label and accessible name should be the same and must not be too different.
See WCAG 2.5.3 https://www.w3.org/WAI/WCAG22/Understanding/label-in-name.html

@joshtrichards

Copy link
Copy Markdown
Member

must not be too different

"More" and "More actions" seem about as similar as can be, but it does seem best to avoid whenever possible - I.e. if there is not a compelling enough benefit to creating a discrepancy.

@susnux

susnux commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Needs adjustment of core/src/tests/components/AppMenu.spec.ts

注册 for free to join this conversation on GitHub. Already have an account? 登录 to comment

标签

3. to review Waiting for reviews backport-request design Design, UI, UX, etc. papercut Annoying recurring UX issue with possibly simple fix.

项目

None yet

Development

Successfully merging this pull request may close these issues.

4 participants