Do not parameterize RootModel bases in generated types - #3413
Open
Viicos wants to merge 1 commit into
Open
Conversation
Contributor
📚 Documentation preview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
注册 for free
to join this conversation on GitHub.
Already have an account?
登录 to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parameterized, a
RootModelis usable directly as a type:However, when used as a base, the model build logic ends up running for nothing, because everything is overridden by the actual class:
By leaving models unparameterized, we gain some performance improvements on startup time: measured locally with
hyperfine --warmup 3 --runs 50 'PYDANTIC_DISABLE_PLUGINS=1 python -c "from mcp_types import _types, _v2025_11_25, _v2026_07_28"':before: 180ms, after: 170ms
I don't know if implementing a Jinja template is the right approach (there's a bit of duplication), but looks like it will be robust enough.
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Performance
Checklist
help wanted, or I'm a maintainer)Additional context