agentHost: preserve remote sessions across reload - #333251
Draft
roblourens wants to merge 2 commits into
Draft
Conversation
Keep non-file working directory URIs returned by listSessions in client space so remote workspace filtering treats live and restored sessions consistently.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: None
What changed in this PR
Preserves remote session visibility after reload by avoiding double-wrapping client-addressed URIs.
Changes:
- Maps only host-local
file:URIs into client space. - Adds regression coverage for live notifications and restored listings.
| File | Description |
|---|---|
agentHostProtocolClient.ts |
Preserves non-file session and project URIs. |
agentHostProtocolClient.test.ts |
Tests remote URI preservation across listing restoration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
注册 for free
to join this conversation on GitHub.
Already have an account?
登录 to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
listSessionsRoot cause
Remote SSH sessions are announced with
vscode-remote:working directories. The coldlistSessionspath wrapped those URIs again asvscode-agent-host:, so workspace filtering excluded the session after window reload even though it still existed in the Agent Host.Validation
npm run compilenpm run typecheck-clientAgentHostProtocolClientlistSessionstests(Written by Copilot)