Fix Bash path interpretation for Windows terminal by akashdeepmaity4 · Pull Request #26125 · microsoft/vscode-python

Akash (akashdeepmaity4) · 2026-08-23T14:36:43Z

Fixed path interpretation issues for Bash commands in Windows, ensuring proper command and argument formatting. Check recent issues submitted by Akash (@akashdeepmaity4) to reproduce issue and get more details.

Fixed path interpretation issues for Bash commands in Windows, ensuring proper command and argument formatting.

Akash (akashdeepmaity4) · 2026-08-23T14:43:27Z

Akash (Akash (@akashdeepmaity4)) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”), and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your contributions to Microsoft open source projects. This Agreement is effective as of the latest signature date below.

Definitions.
“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to Microsoft under this Agreement.
“Project” means any of the projects owned or managed by Microsoft and offered under a license
approved by the Open Source Initiative (www.opensource.org).
“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.

Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.

Originality of Work. You represent that each of Your Submissions is entirely Your original work.
Should You wish to Submit materials that are not Your original work, You may Submit them separately
to the Project if You (a) retain all copyright and license information that was in the materials as You
received them, (b) in the description accompanying Your Submission, include the phrase “Submission
containing materials of a third party:” followed by the names of the third party and any licenses or other
restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
guidelines concerning Submissions.

Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.

Licenses.

Copyright License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
parties.

Patent License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.

Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.

Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
You later become aware that would make Your representations in this Agreement inaccurate in any
respect.

Information about Submissions. You agree that contributions to 项目 and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.

Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.

Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

@microsoft-github-policy-service agree

Bill Schnurr (bschnurr) · 2026-08-28T20:23:53Z

🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR.

Bill Schnurr (bschnurr) · 2026-08-28T20:34:03Z

+
+    // Ship the cleanly escaped string to the terminal stream!
+    this.terminal!.sendText(text, true);
+}


Issue · Please address or respond

These duplicated statements are directly in the class body, reference method-local variables, and introduce an extra closing brace, so the file cannot compile. Remove this entire duplicated block.

Bill Schnurr (bschnurr) · 2026-08-28T20:34:11Z

+                let safeArg = arg.replace(/\\/g, '/');
+                safeArg = safeArg.replace(/^([A-Za-z]):/, (_, drive) => `/${drive.toLowerCase()}`);
+                return safeArg;
+            });


Warning · Non-blocking recommendation

Replacing backslashes in every argument treats opaque values such as regular expressions or Python snippets as paths and can corrupt them. Restrict conversion to known path operands or move normalization into an API that can identify paths.

Updated to Strict Path Operand Normalization. Now, only true paths are considered and regexes are rejected. Up for review

Bill Schnurr (bschnurr) · 2026-08-28T20:34:17Z

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Result: could-not-verify

Summary: No meaningful test executed because the verification container could not start. Static inspection found duplicate statements at class scope in `service.ts`, which makes the PR head syntactically invalid. No tests were added, and existing terminal tests do not cover the new Bash path conversion.

Test runs: 1 not run

⚠️ Not run | Dependency and targeted-test discovery | git status --short && git branch --show-current && git diff --name-status upstream/main...HEAD && git diff --stat upstream/main...HEAD && git diff --unified=80 upstream/main...HEAD -- src\client\common\terminal\service.ts && node -e "const p=require('./package.json'); console.log(JSON.stringify({scripts:p.scripts},null,2))" && if exist node_modules (echo NODE_MODULES_PRESENT) else (echo NODE_MODULES_MISSING) && git ls-files "src/client/common/terminal/test" "src/**/test/*terminal"

⚠️

Dependency and targeted-test discovery diagnostic output

Container verification could not start: no trusted sandbox image is configured for microsoft/vscode-python, and local execution was not authorized.

Removed deprecated logic for stitching command and arguments in terminal service.

Akash (akashdeepmaity4) · 2026-08-30T05:59:33Z


-    // Standard VS Code logic to stitch the command and arguments together
-    const text = processedArgs.reduce((p, c) => `${p} "${c}"`, processedCommand);
-


removed dupes

Refactor command processing for Bash compatibility and restore command execution logic.

Key Changes Applied: Preserved Architecture Pipeline: Routes processedCommand and processedArgs back through this.terminalHelper.buildCommandForTerminal(...) and this.executeCommand(...) to retain shell-aware escaping, shell integration capabilities, and cross-platform handling. Strict Path Operand Normalization: Avoids naive path regexes like /^[A-Za-z]:\\|\\/ which corrupt CLI flags, regex patterns, or inline snippets (e.g., -c, --option, or Python code with \n). Converts only explicit file paths (e.g., C:\path\to\file or .\path\to\file). Cleaned Class Hierarchy: Removed all dangling/duplicate outer-scope statements to maintain clean TypeScript compilation.

Akash (akashdeepmaity4)

Cleaned Class Hierarchy
Strict Path Operand Normalization
Preserved Architecture Pipeline
Removed duplicacies
Removed/fixes orphaned brackets

Akash (akashdeepmaity4) · 2026-08-30T06:06:23Z

+                let safeArg = arg.replace(/\\/g, '/');
+                safeArg = safeArg.replace(/^([A-Za-z]):/, (_, drive) => `/${drive.toLowerCase()}`);
+                return safeArg;
+            });


Updated to Strict Path Operand Normalization. Now, only true paths are considered and regexes are rejected. Up for review

Fix Bash path interpretation for Windows terminal

b6e058e

Fixed path interpretation issues for Bash commands in Windows, ensuring proper command and argument formatting.

Bill Schnurr (bschnurr) reviewed Aug 28, 2026

View reviewed changes

Comment thread src/client/common/terminal/service.ts Outdated

Bill Schnurr (bschnurr) reviewed Aug 28, 2026

View reviewed changes

Bill Schnurr (bschnurr) added the review-auto:changes-requested Automated review: posted blocking findings to address. label Aug 28, 2026

Akash (akashdeepmaity4) added 2 commits August 30, 2026 11:17

Merge branch 'main' into patch-1

4a7fe36

Remove dupes

753eff1

Removed deprecated logic for stitching command and arguments in terminal service.

Akash (akashdeepmaity4) commented Aug 30, 2026

View reviewed changes

Akash (akashdeepmaity4) added 2 commits August 30, 2026 11:31

refactoring code as per reviewer's directions

032008d

Refactor command processing for Bash compatibility and restore command execution logic.

Akash (akashdeepmaity4) commented Aug 30, 2026

View reviewed changes

Navigation Menu

Uh oh!

Fix Bash path interpretation for Windows terminal - #26125

Fix Bash path interpretation for Windows terminal#26125
Akash (akashdeepmaity4) wants to merge 5 commits into
microsoft:mainfrom
akashdeepmaity4:patch-1

Akash (akashdeepmaity4) commented Aug 23, 2026

Uh oh!

Akash (akashdeepmaity4) commented Aug 23, 2026

Contribution License Agreement

Uh oh!

Bill Schnurr (bschnurr) commented Aug 28, 2026 •

edited

Loading

Uh oh!

Bill Schnurr (bschnurr) Aug 28, 2026

Uh oh!

Uh oh!

Bill Schnurr (bschnurr) Aug 28, 2026

Uh oh!

Akash (akashdeepmaity4) Aug 30, 2026

Uh oh!

Bill Schnurr (bschnurr) commented Aug 28, 2026

Uh oh!

Akash (akashdeepmaity4) Aug 30, 2026

Uh oh!

Akash (akashdeepmaity4) left a comment

Uh oh!

Akash (akashdeepmaity4) Aug 30, 2026

Uh oh!

Reviewers

Assignees

标签

项目

Milestone

Development

Uh oh!

2 participants


		// Standard VS Code logic to stitch the command and arguments together
		const text = processedArgs.reduce((p, c) => `${p} "${c}"`, processedCommand);

Uh oh!

Conversation

Akash (akashdeepmaity4) commented Aug 23, 2026

Uh oh!

Akash (akashdeepmaity4) commented Aug 23, 2026

Contribution License Agreement

Uh oh!

Bill Schnurr (bschnurr) commented Aug 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Bill Schnurr (bschnurr) Aug 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Bill Schnurr (bschnurr) Aug 28, 2026

Choose a reason for hiding this comment

Uh oh!

Akash (akashdeepmaity4) Aug 30, 2026

Choose a reason for hiding this comment

Uh oh!

Bill Schnurr (bschnurr) commented Aug 28, 2026

Uh oh!

Akash (akashdeepmaity4) Aug 30, 2026

Choose a reason for hiding this comment

Uh oh!

Akash (akashdeepmaity4) left a comment

Choose a reason for hiding this comment

Uh oh!

Akash (akashdeepmaity4) Aug 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

标签

项目

Milestone

Development

Uh oh!

2 participants

Bill Schnurr (bschnurr) commented Aug 28, 2026 •

edited

Loading