Emit shadow Rush lifecycle events - #5991
Conversation
|
Independent R3 review against #5976/RFC phase 3: lifecycle/result ordering, phase-aware operation scope, legacy error correlation, telemetry projection, and no-raw-output behavior are correctly isolated while |
53d6d5d to
e81d5a2
比较
|
Combined deep review of current head
|
e81d5a2 to
8255a72
比较
|
Rebased the single R3B commit onto #5988 head Fixed Validation: build through Low follow-on: keep the outer telemetry privacy gate until #5990 reaches shared main. Then remove it and forward all envelopes to the hardened subscriber. |
|
Four-review rerun on Required fix: make final command or session completion, or current-iteration outcomes, establish the recovered success result. Add a fail-then-success watch test. Dismissible low follow-ons: reset group |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d6318e80-5da9-4858-a147-817e8692f10e
8255a72 to
2f9ac7d
比较
|
Round two fixed at Derived exit now follows current operation outcomes and authoritative root Validation passed: build through |
|
Final combined review of One intentional low follow-on remains: remove the outer telemetry privacy gate after #5990 reaches shared ancestry. This head is low-only. |
Part of #5976
Stack parent: #5988
Summary
RUSH_OPERATION_FAILEDdiagnostics without routing raw chunksAlreadyReportedErrorfailures so catch boundaries do not emit duplicate structured diagnosticsTelemetrySubscriberprojection into existing Rush telemetry while leaving process exit behavior authoritativeRUSH_COMMAND_FAILEDdiagnostic for representative uncorrelated command failuresValidation
rush installrush build --to @microsoft/rushrush test --only @rushstack/rush-reporter --only @microsoft/rush-lib --only @microsoft/rushrush checkrush change --verifyNo-output guarantee
Legacy terminal rendering and
StreamCollatorremain the only visible stdout/stderr owners. The shadow sink emits no terminal text, operation chunks are not routed to reporters, and focused tests compare legacy graph output with and without the reporter adapter.Non-goals
StreamCollatoror emitting the R5 raw operation/output stream