Skip to content

fix(cli): stop daemon when socket disappears - #42454

Open
Devin Rousso (dcrousso) wants to merge 1 commit into
microsoft:mainfrom
dcrousso:fix-42428
Open

fix(cli): stop daemon when socket disappears#42454
Devin Rousso (dcrousso) wants to merge 1 commit into
microsoft:mainfrom
dcrousso:fix-42428

Conversation

@dcrousso

Copy link
Copy Markdown
Contributor

detached browser daemons stay alive after losing their control socket

monitor the socket identity and exit gracefully when it disappears or is replaced

fixes #42428

detached browser daemons stay alive after losing their control socket

monitor the socket identity and exit gracefully when it disappears or is replaced
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

3 failed
❌ [firefox] › mcp/annotate.spec.ts:291 › should enter annotate mode on fresh dashboard.tsx mount with -s --annotate @mcp-windows-latest-firefox
❌ [firefox] › mcp/annotate.spec.ts:316 › should annotate via direct browser_annotate MCP call @mcp-windows-latest-firefox
❌ [firefox] › mcp/cli-core.spec.ts:140 › uncheck @mcp-windows-latest-firefox

8264 passed, 1366 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 CI is clear — all three failures are pre-existing Firefox flakes

Hi, I'm the Playwright bot and I took a first look at the CI failures.

The three failures are all Firefox-only MCP tests that have nothing to do with this change. This PR only touches the CLI daemon's socket monitor (daemon.ts) and its test — it doesn't go near the MCP annotate flow or the uncheck interaction. Each of the three has a long green history and has failed on other PRs and push runs the PR can't be responsible for, so these are flakes, not regressions.

Details

Overall: none of the failures are caused by this PR. The diff adds monitorSocketPath() in packages/playwright-core/src/tools/cli-daemon/daemon.ts plus a cli-session.spec.ts test — a Unix-socket-identity poll for the browser daemon. That code path is unrelated to the annotate MCP tool and to browser_uncheck, and all three failures reproduce elsewhere.

Pre-existing flake / infra

Triaged by the Playwright bot - agent run

注册 for free to join this conversation on GitHub. Already have an account? 登录 to comment

标签

None yet

项目

None yet

Development

Successfully merging this pull request may close these issues.

[CLI]: Add owner lease or idle timeout for detached browser daemons

1 participant