Skip to content

Handle tsc watch and profiling signals - #64085

Draft
Jake Bailey (jakebailey) wants to merge 2 commits into
microsoft:mainfrom
jakebailey:redo-redo-4592
Draft

Handle tsc watch and profiling signals#64085
Jake Bailey (jakebailey) wants to merge 2 commits into
microsoft:mainfrom
jakebailey:redo-redo-4592

Conversation

@jakebailey

Copy link
Copy Markdown
Member

Fixes #63856

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes unresponsive tsc interruption by scoping signal handling to watch mode and preserving profiling output during termination.

Changes:

  • Adds reusable termination-signal utilities.
  • Flushes profiles before re-raising termination signals.
  • Configures watch-specific cancellation and adds Unix profiling coverage.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tsc/cmd/tsc/main.go Configures watch signal handling.
tsc/internal/execute/tsc.go Applies signal contexts to unprofiled watch modes.
tsc/internal/osutil/osutil.go Adds termination notification helpers.
tsc/internal/osutil/signal_unix.go Re-raises Unix signals.
tsc/internal/osutil/signal_other.go Provides the non-Unix fallback.
tsc/internal/pprof/pprof.go Flushes profiles safely upon termination.
tsc/internal/pprof/pprof_unix_test.go Tests profile flushing on SIGINT.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread tsc/cmd/tsc/main.go
Comment thread tsc/internal/pprof/pprof_unix_test.go Outdated
注册 for free to join this conversation on GitHub. Already have an account? 登录 to comment

标签

None yet

项目

None yet

Development

Successfully merging this pull request may close these issues.

tsc is not resposive to ctrl-c

2 participants