Skip to content

feat: add auto-exit on empty list and improve bindings - #95

Draft
LangLangBart wants to merge 9 commits into
mainfrom
auto_mark_read
Draft

feat: add auto-exit on empty list and improve bindings#95
LangLangBart wants to merge 9 commits into
mainfrom
auto_mark_read

Conversation

@LangLangBart

@LangLangBart LangLangBart commented Aug 11, 2024

Copy link
Copy Markdown
Collaborator

Description

When pressing ⌃ Control + T or ⏎ Enter, the notification is automatically marked as read. When the list is empty, the program exits automatically after a reload.

In the GIF below, the old behavior reloads the list with a message while fzf remains active. The new behavior will exit fzf if the list becomes empty after pressing Ctrl + T.

Pro

  • Fewer hotkey presses
  • Viewing notifications would mimic the behavior of the GitHub web interface by automatically marking notifications as read

Negative

  • Requires fzf 0.45.0, but many package repositories still ship quite outdated fzf versions1
    • Because of that reason is is just a draft

Footnotes

  1. https://repology.org/project/fzf/versions

注册 for free to join this conversation on GitHub. Already have an account? 登录 to comment

标签

None yet

项目

None yet

Development

Successfully merging this pull request may close these issues.

1 participant