Skip to content

Mark done - #91

Open
sitano wants to merge 2 commits into
meiji163:mainfrom
sitano:mark_done
Open

Mark done#91
sitano wants to merge 2 commits into
meiji163:mainfrom
sitano:mark_done

Conversation

@sitano

@sitano sitano commented Jul 19, 2024

Copy link
Copy Markdown

Allow the user to select and delete/done notifications with ctrl-x.
I changed individual Done to ctrl-x and comment to ctrl-c. Not sure about what are good keys for that.
in continuation of #90.

Signed-off-by: Ivan Prisyazhnyy <john.koepi@gmail.com>
@LangLangBart

Copy link
Copy Markdown
Collaborator

rebased

@LangLangBart

Copy link
Copy Markdown
Collaborator

Comment to ctrl-c.

⌃ Control + C is typically used for canceling. Set it to ⌃ Control + O for now.

Done to ctrl-x

Okay.


The issue is that there is no done field, as mentioned in the referenced issue. Therefore, I won't merge it for now unless GitHub adds this feature or @meiji163 also desires this feature.

@sitano sitano mentioned this pull request Jul 23, 2024
@sitano

sitano commented Jul 23, 2024

Copy link
Copy Markdown
Author

@LangLangBart I see your point. Responded in #47 (comment).

@sideshowbarker

Copy link
Copy Markdown

What about having the mark-as-done action mark the notification as both done and read?

See #100 for a working proof of concept.

While only marking the notification as done doesn’t have any visible effect in the UI, marking the notification as both done and read has the same effect in the UI as marking the notification as read — that is, it removes it from the list of notifications.

I’d think that would be the effect that most users might want for a mark-as-done action.

注册 for free to join this conversation on GitHub. Already have an account? 登录 to comment

标签

None yet

项目

None yet

Development

Successfully merging this pull request may close these issues.

3 participants