Skip to content

Use self-sizing collection view cells in the example - #285

Merged
lucdion merged 4 commits into
masterfrom
improvement/list_example
Aug 30, 2026
Merged

Use self-sizing collection view cells in the example#285
lucdion merged 4 commits into
masterfrom
improvement/list_example

Conversation

@heoblitz

@heoblitz heoblitz commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

What is this PR for?

Remove the collection view’s template cell and use UIKit self-sizing instead.

Changes

  • Size HouseCell with preferredLayoutAttributesFitting(_:)
  • Use FlexLayout for the final fitting size
  • Remove unused example code

Tests

SPM Example build & simulator run ✅

@heoblitz
heoblitz marked this pull request as ready for review August 8, 2026 10:38
@heoblitz
heoblitz requested a review from lucdion August 12, 2026 06:59

@lucdion lucdion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👌

@heoblitz

Copy link
Copy Markdown
Collaborator Author

@lucdion Ah, it looks like I don’t have merge permission. Could I also get access to PinLayout?

I’d like to check the issues when I have time. Thanks!

@lucdion

lucdion commented Aug 13, 2026

Copy link
Copy Markdown
Member

@heoblitz , you should have merge permission, you have Write permission.
Capture d’écran, le 2026-08-13 à 15 42 57

I have added you in PinLayout.

@heoblitz

Copy link
Copy Markdown
Collaborator Author

@lucdion Ah, I see — this may be due to a branch protection rule. Could you update “Restrict who can push to matching branches” for master to allow merging approved PRs? The existing approval and CI requirements can remain unchanged.

image

@lucdion
lucdion merged commit 320a19f into master Aug 30, 2026
2 checks passed
@lucdion
lucdion deleted the improvement/list_example branch August 30, 2026 00:49
@lucdion

lucdion commented Aug 30, 2026

Copy link
Copy Markdown
Member

Ok, done, you can now merge PRs

注册 for free to join this conversation on GitHub. Already have an account? 登录 to comment

标签

None yet

项目

None yet

Development

Successfully merging this pull request may close these issues.

2 participants