Skip to content

Remove deprecated shell_streams and _parent_header shims - #1504

Draft
erikgaas wants to merge 3 commits into
ipython:mainfrom
erikgaas:remove-shell-streams
Draft

Remove deprecated shell_streams and _parent_header shims#1504
erikgaas wants to merge 3 commits into
ipython:mainfrom
erikgaas:remove-shell-streams

Conversation

@erikgaas

@erikgaas erikgaas commented Mar 6, 2026

Copy link
Copy Markdown

Summary

Remove two deprecated compatibility shims from ipykernel 6.0 (2021):

  • shell_streams (plural) — deprecated in favor of shell_stream (singular)
  • _parent_header property — deprecated in favor of get_parent()

Both have been emitting DeprecationWarning for 5 years.

Changes

  • Remove shell_streams trait, _shell_streams_default, and _shell_streams_changed from kernelbase.py
  • Remove _parent_header deprecated property from kernelbase.py
  • Remove test_deprecated_features test that covered both

No behavioral change — shell_stream and get_parent() remain the supported APIs.

@erikgaas erikgaas changed the title Remove deprecated shell_streams shim Remove deprecated shell_streams and _parent_header shims Mar 6, 2026
@Carreau Carreau added this to the 7.3 milestone May 7, 2026
@Carreau
Carreau force-pushed the remove-shell-streams branch from 8466774 to 0990345 比较 May 7, 2026 08:34
@Carreau

Carreau commented May 7, 2026

Copy link
Copy Markdown
Member

Marking for 7.3, I always like removals.

erikgaas and others added 3 commits June 10, 2026 09:05
shell_streams (plural) was deprecated in ipykernel 6.0 (2021) in favor of
shell_stream (singular). Remove the trait, default handler, observer, and
associated test.
@Carreau
Carreau force-pushed the remove-shell-streams branch from 0990345 to 682aaec 比较 June 10, 2026 07:05
@Carreau

Carreau commented Jun 10, 2026

Copy link
Copy Markdown
Member

there seem to be real error in CI with ipyparallel; not sure why it just hangs after a while

@Carreau Carreau removed this from the 7.3 milestone Jun 10, 2026
minrk pushed a commit to ipython/ipyparallel that referenced this pull request Jun 10, 2026
@Carreau

Carreau commented Jun 11, 2026

Copy link
Copy Markdown
Member

Fixed change in ipyparallel; this will need to wait a few month that the new version released and used more

@Carreau
Carreau marked this pull request as draft June 11, 2026 09:50
注册 for free to join this conversation on GitHub. Already have an account? 登录 to comment

项目

None yet

Development

Successfully merging this pull request may close these issues.

2 participants