fix(modal): prevent ion-content collapsing at content-based heights - #31413
Draft
brandyscarney wants to merge 2 commits into
Draft
fix(modal): prevent ion-content collapsing at content-based heights#31413brandyscarney wants to merge 2 commits into
brandyscarney wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
注册 for free
to join this conversation on GitHub.
Already have an account?
登录 to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #31149
What is the current behavior?
Setting
--heightto any of the following on anion-modalcontaining anion-contentresults in theion-contentcollapsing to0height:auto,fit-content,min-content, ormax-content.What is the new behavior?
--heightis set toauto,fit-content,min-content,ormax-contentand styles theion-content,ion-navand.ion-pageappropriately if so--max-heightto100%ion-modalhas--heightsetDoes this introduce a breaking change?
Other information
Dev build:
9.0.1-dev.11787949960.1e63841cPreview