Skip to content

[test-parallel] test: add t.Parallel() to safe schedule calendar tests - #56813

Draft
github-actions[bot] wants to merge 1 commit into
mainfrom
daily-go-test-parallelizer-20260829-024356-4a9912cc66220b34
Draft

[test-parallel] test: add t.Parallel() to safe schedule calendar tests#56813
github-actions[bot] wants to merge 1 commit into
mainfrom
daily-go-test-parallelizer-20260829-024356-4a9912cc66220b34

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Daily Go Test Parallelizer

Analyzed batch of 25 test files in pkg/cli/ (following round-robin from pkg/cli/compile_dir_flag_test.go):

compile_engine_env_needs_integration_test.go
compile_experiments_integration_test.go
compile_external_tools_test.go
compile_force_refresh_action_pins_test.go
compile_guard_policy_report_test.go
compile_guard_policy_test.go
compile_instructions_test.go
compile_integration_test.go
compile_json_output_test.go
compile_maintenance_test.go
compile_max_turns_import_integration_test.go
compile_model_fallback_integration_test.go
compile_orchestrator_container_pins_test.go
compile_orchestrator_host_test.go
compile_orchestrator_stability_test.go
compile_permissions_integration_test.go
compile_pipeline_purge_test.go
compile_pipeline_shellcheck_resources_test.go
compile_pipeline_yamllint_test.go
compile_post_processing_warning_test.go
compile_pull_request_target_integration_test.go
compile_repository_manifest_test.go
compile_safe_outputs_needs_imports_integration_test.go
compile_safe_update_integration_test.go
compile_schedule_calendar_test.go

Findings

Most files in this batch were unsafe to parallelize due to os.Chdir, os.Setenv/t.Setenv, integration-test CLI subprocess invocation with shared fixture directories, or package-level global/function-variable overrides (e.g. compileUpdateContainerPins, runBatchYamllintOnFiles, styles.ScheduleCalendarCritical, redirected os.Stdout/os.Stderr).

Several candidate files (compile_external_tools_test.go, compile_force_refresh_action_pins_test.go, compile_pipeline_purge_test.go) already had t.Parallel() on all their safe top-level tests, so no change was needed there.

In compile_schedule_calendar_test.go, two self-contained top-level tests were missing t.Parallel():

  • TestRenderScheduleCalendarCell_NoANSIWhenNotTerminal
  • TestRenderScheduleCalendarCell_NoANSIWhenNoColor

Both only call the pure function renderScheduleCalendarCell with local data (no globals, no env, no filesystem, no shared state) and are safe to parallelize. The sibling test TestRenderScheduleCalendarCell_UsesANSIInColorTerminal was intentionally left non-parallel — it mutates the shared package-level styles.ScheduleCalendarCritical style token.

Validation

  • go test -race ./pkg/cli/... -run '...' (targeted to touched/candidate tests): all pass.
  • go build ./...: succeeds.
  • Diff reviewed: only the two t.Parallel() additions, no other changes.

Note: TestRenderScheduleCalendarCell_UsesANSIInColorTerminal fails both before and after this change (pre-existing, unrelated to this PR — confirmed via git stash).

State

Cache updated: last_file = ./pkg/cli/compile_schedule_calendar_test.go for the next round-robin run.

Generated by Daily Go Test Parallelizer · copilot · auto · 51.9 AIC · ⌖ 9.45 AIC · ⊞ 8.6K ·

  • expires on Aug 31, 2026, 6:46 PM UTC-08:00

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
注册 for free to join this conversation on GitHub. Already have an account? 登录 to comment

项目

None yet

Development

Successfully merging this pull request may close these issues.

0 participants