Fix Playwright MCP TOML sandbox configuration#56800
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot update an agentic workflow that uses pnaywrigjt to use codex to test this |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Updated |
There was a problem hiding this comment.
🟡 Changes recommended
Custom Playwright arguments now produce invalid TOML due to duplicate comma emission.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds Chromium’s --no-sandbox flag to TOML-rendered Playwright MCP configurations and exercises it through the Codex smoke workflow.
Changes:
- Adds the Playwright launch flag and regression coverage.
- Migrates the Codex smoke test from Playwright CLI to MCP.
- Regenerates the compiled workflow.
File summaries
| File | Description |
|---|---|
pkg/workflow/mcp_renderer_builtin.go |
Adds --no-sandbox to TOML output. |
pkg/workflow/mcp_config_refactor_test.go |
Checks required Playwright flags. |
.github/workflows/smoke-codex.md |
Tests Playwright through MCP. |
.github/workflows/smoke-codex.lock.yml |
Regenerates the compiled workflow. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| yaml.WriteString(" \"/tmp/gh-aw/mcp-logs/playwright\",\n") | ||
| yaml.WriteString(" \"--no-sandbox\",\n") |
There was a problem hiding this comment.
Fixed in 2bc3036. The built-in --no-sandbox argument is now unterminated so writeArgsToYAML can insert the separator before custom arguments; regression coverage verifies the resulting sequence.
|
@copilot Please refresh this PR for forward progress. Re-run the
|
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
|
@copilot There is still review feedback on this PR about the TOML rendering regression. Please address the duplicate-comma TOML issue noted by Copilot review, refresh the branch if needed, and then run the Current review feedback, newest first:
Run: https://github.com/github/gh-aw/actions/runs/33246040923 Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "github.com"See 网络 Configuration for more information.
|
The duplicate-comma regression is already fixed in 2bc3036, with focused custom-argument coverage. I refreshed the branch with main (108a138) and re-ran formatting, lint, unit tests, full tests, and workflow recompilation successfully. |
Playwright MCP configurations rendered as TOML omitted Chromium’s
--no-sandboxflag, unlike JSON-rendered configurations. This could prevent browser startup in sandboxed environments.TOML renderer
--no-sandboxto Playwright MCP entrypoint arguments.Regression coverage
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
github.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See 网络 Configuration for more information.