[WIP] Fix failing GitHub 操作 job for misc part 2#56689
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot resolve the merge conflicts on this branch. |
There was a problem hiding this comment.
Pull request overview
Updates workflow tests for explicit opt-in engine domains, addressing the referenced integration failure.
Changes:
- Removes implicit Copilot and Claude domain expectations.
- Retains explicit network, API-target, and sanitization domain checks.
Show a summary per file
| File | Description |
|---|---|
pkg/workflow/security_regression_test.go |
Updates default-network expectations. |
pkg/workflow/domains_protocol_integration_test.go |
Removes an implicit Copilot domain expectation. |
pkg/workflow/allowed_domains_sanitization_test.go |
Revises sanitization and network-union expectations. |
Review details
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Suppressed comments (2)
pkg/workflow/allowed_domains_sanitization_test.go:137
- The empty expected list makes this case assert only that the environment variable exists; it does not verify that implicit Copilot domains are absent. Add positive checks for the sanitization defaults and a negative check for an engine-only domain so the new explicit-opt-in behavior is covered.
expectedDomains: []string{},
unexpectedDomain: "",
pkg/workflow/allowed_domains_sanitization_test.go:409
- As with the preceding Copilot case, an empty
expectedDomainsslice and no unexpected domains produce no result assertion. A regression that restores Claude or ecosystem defaults for a nil network would still pass this test.
expectedDomains: []string{},
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Balanced
|
@copilot Please refresh this branch if needed, review the latest feedback/check status, and then run the
Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "github.com"See 网络 Configuration for more information.
|
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Resolved the conflict with |
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Refreshed the branch and completed PR-finisher validation. Review feedback is addressed in |
|
@copilot Please refresh this branch if needed, review the latest feedback/check status, and then run the Run: https://github.com/github/gh-aw/actions/runs/33224630096
|
…on-workflow-misc-part-2 Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Refreshed the branch with current |
|
@copilot Two unresolved review threads already have substantive follow-up on the current head. Please confirm the PR is maintainer-ready, refresh branch/check state if needed, and run the Current unresolved review threads, newest first:
Your replies indicate both assertions were restored on Run: https://github.com/github/gh-aw/actions/runs/33231241207 Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "github.com"See 网络 Configuration for more information.
|
Confirmed both review threads are now resolved on current head |
|
@copilot Please refresh this branch if needed, verify the latest review and check state on the current head commit, and then run the Run: https://github.com/github/gh-aw/actions/runs/33234948407
|
…on-workflow-misc-part-2 Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Refreshed the branch with the latest |
|
@copilot Please refresh this PR for forward progress. Re-run the
|
|
Category: bug | Risk: medium | Score: 58/100 (impact 26/50, urgency 18/30, quality 14/20) | Action: batch_review | Batch: workflow-safety | Note: Addresses a failing workflow job, but the PR remains lightweight and lacks CI signal.
|
…on-workflow-misc-part-2 Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Refreshed from current |
|
@copilot Please refresh this PR for forward progress. Re-run the Run: https://github.com/github/gh-aw/actions/runs/33246602890
|
Refreshed the PR state and reran final local validation. The branch is current with |
|
@copilot Please refresh this PR for forward progress. Re-run the Run: https://github.com/github/gh-aw/actions/runs/33251251524 Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "github.com"See 网络 Configuration for more information.
|
Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
github.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See 网络 Configuration for more information.
Automated branch refresh attempt from PR Sous Chef run https://github.com/github/gh-aw/actions/runs/33246602890.