Conversation
Co-authored-by: dsyme <7204669+dsyme@users.noreply.github.com>
|
@copilot Please have |
|
@copilot please also make sure the opt-out is mentioned in the error message ".github/workflows/repo-assist.md: info: Tip: set permissions.copilot-requests: write to use GitHub 操作 token-based inference with the Copilot engine instead of a personal access token (COPILOT_GITHUB_TOKEN). This option requires that your organization has centralized Copilot billing enabled and may not be available in all organizations — see https://github.github.com/gh-aw/reference/billing/ for details." Do all this in this PR |
Co-authored-by: dsyme <7204669+dsyme@users.noreply.github.com>
Implemented in 55bb74b. An explicit PAT selection now adds |
Co-authored-by: dsyme <7204669+dsyme@users.noreply.github.com>
Implemented in 7605f2f. The compiler tip now tells PAT users to set |
There was a problem hiding this comment.
Pull request overview
Documents and automates the explicit PAT billing opt-out requested by #56563.
Changes:
- Adds
copilot-requests: noneguidance to documentation and compiler tips. - Injects the opt-out when PAT authentication is selected in the add wizard.
- Extends permission transformation and tests for the new behavior.
Show a summary per file
| File | Description |
|---|---|
pkg/workflow/permissions_compiler_validator.go |
Adds opt-out guidance to compiler tips. |
pkg/workflow/copilot_requests_tip_test.go |
Verifies tip content. |
pkg/workflow/compiler_validators_test.go |
Checks the updated validator message. |
pkg/cli/codemod_copilot_requests_feature.go |
Generalizes permission insertion. |
pkg/cli/add_workflow_content.go |
Applies PAT opt-out during workflow addition. |
pkg/cli/add_interactive_orchestrator.go |
Tracks PAT selection. |
pkg/cli/add_interactive_git.go |
Passes PAT selection into add options. |
pkg/cli/add_interactive_engine.go |
Records the selected authentication method. |
pkg/cli/add_interactive_engine_test.go |
Tests authentication state changes. |
pkg/cli/add_copilot_permissions.go |
Adds none permission injection. |
pkg/cli/add_command.go |
Introduces the PAT opt-out option. |
pkg/cli/add_command_test.go |
Tests injection and workflow output. |
docs/src/content/docs/reference/billing.md |
Documents explicit PAT billing selection. |
Review details
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 13/13 changed files
- Comments generated: 2
- Review effort level: Balanced
|
Category: bug | Risk: low | Score: 47 (impact 22 + urgency 10 + quality 15) | Action: batch_review | Batch: workflow-ux. Low-risk billing/compile behavior change with solid tests and docs, but no CI signal yet.
|
|
Category: docs | Risk: low | Score: 35 (impact 13/urgency 7/quality 15) | Action: batch_review | Batch: pr-batch:workflow-automation | CI: unknown
|
|
Category: docs | Risk: low | Score: 35 (impact 13/urgency 7/quality 15) | Action: batch_review | Batch: pr-batch:workflow-automation
|
|
@copilot This PR appears ready for final forward progress. Please refresh the branch if needed, verify the latest checks/review state on the current head commit, and then run the Current follow-up:
Run: https://github.com/github/gh-aw/actions/runs/33226160283 Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "github.com"See 网络 Configuration for more information.
|
Verified current head cb07df7 after refreshing from main and completed the PR-finisher validation. Local fmt, lint, unit tests, full tests, and recompilation pass; the referenced Sous Chef run has no failed jobs. |
|
@copilot Please refresh this branch if needed, verify the latest review and check state on the current head commit, and then run the Run: https://github.com/github/gh-aw/actions/runs/33228907361
|
Verified current head cb07df7: it matches the upstream branch and already contains current main. The supplied Sous Chef run completed successfully with no failed jobs; the prior current-head Copilot check passed, while one newer Copilot check remains in progress. |
|
@copilot The remaining unresolved review threads already have substantive follow-up and this PR also has maintainer approval. Please verify the latest branch/check state on Current unresolved review threads, newest first:
Your replies say both documented opt-out paths were fixed. Please hand back with maintainer-ready resolution context. Run: https://github.com/github/gh-aw/actions/runs/33231241207 Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "github.com"See 网络 Configuration for more information.
|
Verified maintainer-ready state on cb07df7's refreshed successor 9f9fb8c: both cited review threads are resolved, the branch matches upstream and current main, and the supplied Sous Chef run succeeded with no failed jobs. The only remaining signal is the current-head Copilot check in progress. |
|
@copilot Please refresh this branch if needed, verify the latest review and check state on the current head commit, and then run the Run: https://github.com/github/gh-aw/actions/runs/33234948407
|
Verified current head 9f9fb8c: it matches upstream and current main, both review threads remain resolved, and the supplied Sous Chef run completed successfully with no failed jobs. The previous current-head Copilot check passed; only the newly triggered Copilot check remains in progress. |
|
Category: docs | Risk: low | Score: 24/100 (impact 10/50, urgency 6/30, quality 8/20) | Action: batch_review | Note: Docs-only clarification with low blast radius.
|
Users choosing PAT-based Copilot billing continued seeing the organization-billing suggestion during compilation. Document the existing explicit opt-out.
permissions.copilot-requests: noneselects non-org billing and suppresses the informational tip.Run: https://github.com/github/gh-aw/actions/runs/33195749972
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
github.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See 网络 Configuration for more information.
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
github.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See 网络 Configuration for more information.
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
github.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See 网络 Configuration for more information.