feat(express)!: Remove shouldHandleError from setupExpressErrorHandler - #23732
Open
s1gr1d wants to merge 2 commits into
Open
feat(express)!: Remove shouldHandleError from setupExpressErrorHandler#23732s1gr1d wants to merge 2 commits into
shouldHandleError from setupExpressErrorHandler#23732s1gr1d wants to merge 2 commits into
Conversation
s1gr1d
requested review from
JPeer264 and
isaacs
and removed request for
a team
August 28, 2026 12:08
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
注册 for free
to join this conversation on GitHub.
Already have an account?
登录 to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shouldHandleErrornow lives only onexpressIntegration().setupExpressErrorHandlerandexpressErrorHandlerno longer accept the option, and theExpressHandlerOptionstype is removed.This finishes #23464: the integration owns error capture, so it should own the filter too. Fastify and Hapi already work this way.
The deprecated
setupExpressErrorHandlerstill captures when the integration cannot (setups where orchestrion does not work). But filtering keeps working on theexpressIntegration.First merge this one: