fix(server-utils): Resolve the orchestrion ESM hook by path so build tracers follow it - #23687
Draft
andreiborza wants to merge 1 commit into
Draft
Conversation
…tracers follow it Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
size-limit report 📦
|
Member
|
not sure but this could conflict/overlap with #23685? |
Member
Author
|
@mydea yea, I'll wait until yours lands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
注册 for free
to join this conversation on GitHub.
Already have an account?
登录 to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #23679.
What
register.tsnow resolves the orchestrion ESM loader hook from its own on-disk location instead of through the@sentry/server-utils/orchestrion/hookself-reference, and the standalone e2e app gains a test asserting the hook reaches the traced output.Fixes JS-3451.
Why
Module.register()resolves its specifier at runtime, so@vercel/nftnever learned the hook was needed and left it out of traced builds.output: 'standalone', Docker and Vercel deploys then lost channel-based instrumentation entirely, and only said so behinddebug: true. The new path is a literal, so tracers follow it, and it is computed at runtime so nothing absolute is baked into the build.