Update skills_lint to published version ^0.5.1 - #9984
Conversation
- Update tool/pubspec.yaml to depend on published skills_lint: ^0.5.1 - Remove TODO comment referencing issue flutter#9771 - Update pubspec.lock Closes flutter#9771
There was a problem hiding this comment.
Code Review
This pull request updates the skills_lint dependency in tool/pubspec.yaml from a Git repository reference to the published version ^0.5.1 on pub.dev, updating pubspec.lock accordingly. It also updates the vm_service dependency version from 15.2.0 to 15.3.0 in pubspec.lock. There are no review comments, and I have no feedback to provide.
|
|
||
| String get id; | ||
|
|
||
| @visibleForTesting |
There was a problem hiding this comment.
This change is unrelated but was causing the tree to go red. Hoping that if it is fixed upstream that I dont have a conflict.
There was a problem hiding this comment.
Code Review
This pull request updates the skills_lint dependency from a git-based dependency to a hosted dependency on pub.dev (version 0.5.1) in both tool/pubspec.yaml and pubspec.lock. Additionally, it updates the vm_service dependency to version 15.3.0 and adds the @visibleForTesting annotation to the durationDisplay getter in network_model.dart. There are no review comments, and I have no feedback to provide.
Update skills_lint to version from pub.dev fixes #9771
Agent authored description
Migrates the
tool/skill validation dependency from Git to the publishedskills_lint: ^0.5.1package on pub.dev.tool/pubspec.yamlto depend onskills_lint: ^0.5.1.pubspec.lock.dart pub get,dart analyze --fatal-infos, anddart test.Closes #9771