MINOR: Reject non zero offset on array import - #1263
Open
robert3005 wants to merge 4 commits into
Open
Conversation
robert3005
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
August 19, 2026 13:35
This comment has been minimized.
This comment has been minimized.
jbonofre
requested changes
Aug 27, 2026
Author
|
Thanks for the suggestion, I applied it and added test to make sure we don't regress it in the future |
Member
|
@robert3005 thanks! I'm doing a new pass 😄 |
Member
|
By the way, we merged a fix on CI, I will rebase. |
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
注册 for free
to join this conversation on GitHub.
Already have an account?
登录 to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Instead of silently accepting the array and pretending the import went fine reject arrays where offset is non 0. Add mention to the docs that this is not supported
This is documentation and negative case for #251