fix(@angular/ssr): ensure public directory containment in CommonEngine - #33957
Merged
alan-agius4 merged 1 commit intoAug 28, 2026
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request improves the path traversal protection in the Angular SSR CommonEngine. It replaces the previous startsWith(normalize(publicPath)) check with a more robust check using relative and isAbsolute from node:path, which is executed before attempting to read any pre-rendered pages. I have no feedback to provide as there are no review comments.
Ensure that paths resolved in `retrieveSSGPage` strictly remain within the configured `publicPath` by checking `relative()` containment before evaluating the static file. Previously, a string `startsWith()` check was used, which could match sibling directories that share the same name prefix as `publicPath`.
alan-agius4
force-pushed
the
fix-common-engine-path-containment-main
branch
from
August 28, 2026 07:56
4ffcaf9 to
b2d30ea
比较
clydin
approved these changes
Aug 28, 2026
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
注册 for free
to join this conversation on GitHub.
Already have an account?
登录 to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that paths resolved in
retrieveSSGPagestrictly remain within the configuredpublicPathby checkingrelative()containment before evaluating the static file.Previously, a string
startsWith()check was used, which could match sibling directories that share the same name prefix aspublicPath.