Emmcio module - #11257
Open
FoamyGuy wants to merge 9 commits into
Open
Conversation
tannewt
requested changes
Aug 27, 2026
tannewt
left a comment
Member
There was a problem hiding this comment.
Getting better! Do we really need to guard so heavily against the emmc not coming up? Since it's on the board I'd expect it to just work.
| #if CIRCUITPY_EMMC_USB | ||
|
|
||
| #ifndef CIRCUITPY_EMMC_MOUNT_PATH | ||
| #define CIRCUITPY_EMMC_MOUNT_PATH "/sd" |
Member
There was a problem hiding this comment.
Are we sure we want this? Or should it be /emmc?
Collaborator
Author
There was a problem hiding this comment.
I had it as /emmc at first and changed it to /sd to be consistent with Yoto devices after it was mentioned that I should try to model this on the work that done in them. Personally I have no strong opinion which it uses.
# Conflicts: # locale/circuitpython.pot # ports/nordic/supervisor/port.c
Member
|
I think you can mark this ready. It looks fine to me. I poked the CI. The two failing tests are in Zephyr and I have a separate PR to extend their timeouts. |
FoamyGuy
marked this pull request as ready for review
August 28, 2026 16:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
注册 for free
to join this conversation on GitHub.
Already have an account?
登录 to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds
emmciomodule with support for auto-mounting at/sd.Some changes based on feedback in the prior PR:
automount_status(), it had no analogy in sdcardio or sdioio.Currently compile tested only. Testing on hardware requires SP-1 board def which I'm working on next and then will make a local merged branch to validate the behavior of this branch. Will un-draft after it's tested
Question from previous PR review:
The module isn't speaking SPI. It's the 1-bit MMC bus: a clock, a bidirectional CMD line, and a bidirectional DAT0 line. SPIM3 is being used as a raw shift-and-clock engine on a single wire, not as a SPI primary/controller. MOSI and MISO are the same pin, rebound per transfer. The DMA transfer happens mid-frame, between bit-banged phases.