Conversation
Naramsim
commented
Aug 28, 2026
Naramsim
commented
Aug 28, 2026
FallenDeity
requested changes
Aug 29, 2026
| @@ -38,7 +41,7 @@ jobs: | |||
| nohup make serve & | |||
Contributor
There was a problem hiding this comment.
do we need to make serve here we can just all it a day at make build-db right the django server is not being used
| - "**.toml" | ||
| - "**.lock" | ||
| - "data/**" | ||
| - "Resources/nginx/**" |
Contributor
There was a problem hiding this comment.
missing the resources docker app dockerfile
| - "Makefile" | ||
| - "uv.lock" | ||
| - ".github/workflows/code-quality.yml" | ||
| - "**.lock" |
Contributor
There was a problem hiding this comment.
missing the uv setup action, database.yml and release.yml is missing it too btw
|
|
||
| on: | ||
| push: | ||
| paths: |
Contributor
There was a problem hiding this comment.
just a note if we do ever create a release tag which dosent modify these files the image wont release
| push: | ||
| paths: | ||
| - "**.py" | ||
| - "data/**" |
Contributor
There was a problem hiding this comment.
toml and lock files here needed if a dep is bumped ever
resources docker for the docker image
and the uv setup action
ps: same issue as with release tag for docker build and publish
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
注册 for free
to join this conversation on GitHub.
Already have an account?
登录 to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
Run CI only when some files change
AI coding assistance disclosure
nothing
Contributor check list