Preserve separate C# attribute groups - #1895
Open
taljeon wants to merge 1 commit into
Open
Conversation
Signed-off-by: taljeon <169621860+taljeon@users.noreply.github.com>
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
注册 for free
to join this conversation on GitHub.
Already have an account?
登录 to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1865.
C# declarations can contain multiple
attribute_listchildren when attributes use separate bracket groups. Decorator extraction previously looked up only one wrapper, so later groups were omitted from the definition'sdecoratorsarray.This change counts and collects decorators from every annotation wrapper in source order. It also adds a focused regression using separate
[HttpPost]and[Route(...)]groups.Validation
scripts/test.sh --suites extraction— 308 passedCBM_TEST_PAR_JOBS=4 scripts/test.sh— 7,659 passed, 0 failed, 8 platform skips; all prod guards passedscripts/lint.sh --ciwith the CI clang-format 20 and cppcheck toolchainmake -f Makefile.cbm security— all security checks passed, including 32/32 MCP robustness casesgit diff --checkDevelopment note: OpenAI Codex assisted with implementation and verification; I reviewed the change and validation results.
Checklist
git commit -s) — required, CI rejectsunsigned commits (DCO, see CONTRIBUTING.md)
make -f Makefile.cbm test)make -f Makefile.cbm lint-ci)