Skip to content

Preserve separate C# attribute groups - #1895

Open
taljeon wants to merge 1 commit into
DeusData:mainfrom
taljeon:codex/fix-csharp-multiple-attributes
Open

Preserve separate C# attribute groups#1895
taljeon wants to merge 1 commit into
DeusData:mainfrom
taljeon:codex/fix-csharp-multiple-attributes

Conversation

@taljeon

@taljeon taljeon commented Aug 29, 2026

Copy link
Copy Markdown

What does this PR do?

Fixes #1865.

C# declarations can contain multiple attribute_list children when attributes use separate bracket groups. Decorator extraction previously looked up only one wrapper, so later groups were omitted from the definition's decorators array.

This change counts and collects decorators from every annotation wrapper in source order. It also adds a focused regression using separate [HttpPost] and [Route(...)] groups.

Validation

  • scripts/test.sh --suites extraction — 308 passed
  • CBM_TEST_PAR_JOBS=4 scripts/test.sh — 7,659 passed, 0 failed, 8 platform skips; all prod guards passed
  • scripts/lint.sh --ci with the CI clang-format 20 and cppcheck toolchain
  • make -f Makefile.cbm security — all security checks passed, including 32/32 MCP robustness cases
  • git diff --check

Development note: OpenAI Codex assisted with implementation and verification; I reviewed the change and validation results.

Checklist

  • Every commit is signed off (git commit -s) — required, CI rejects
    unsigned commits (DCO, see CONTRIBUTING.md)
  • Tests pass locally (make -f Makefile.cbm test)
  • Lint passes (make -f Makefile.cbm lint-ci)
  • 新建 behavior is covered by a test (reproduce-first for bug fixes)

Signed-off-by: taljeon <169621860+taljeon@users.noreply.github.com>
@taljeon
taljeon requested a review from DeusData as a code owner August 29, 2026 01:36
@github-actions

Copy link
Copy Markdown

Thanks for opening this — it has been seen, and it is queued.

This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence.

Current review status: working through a backlog. 0.9.1-rc.1 is out, so the release freeze that held reviews is over — but it left a large queue of open pull requests behind it, and we are reading through them oldest-first. The background is in discussion #1144.

What that means for this PR, concretely:

  • It will not be closed for inactivity. No stale bot touches pull requests here.
  • It may still sit a while before a human reads it. That is on us, not on you.
  • Older PRs are read first, so a recent one is not being skipped — it is behind a queue.

Things that will genuinely speed it up whenever review does happen:

  • Keep it rebased on main — the tree is moving quickly right now, and a conflicting branch cannot be reviewed as the diff you intended.
  • Get CI green, or say which failures you believe are pre-existing.
  • Keep the change to one claim. Bundled features and refactors get split before they get merged, which costs you a round trip.
  • Every commit needs a sign-off (git commit -s) — CI enforces DCO.

If this fixes a bug, a reproduction we can run is worth more than a description of the symptom.

Thanks for contributing, and sorry in advance for the wait.

注册 for free to join this conversation on GitHub. Already have an account? 登录 to comment

标签

None yet

项目

None yet

Development

Successfully merging this pull request may close these issues.

decorators/query_graph drops one attribute when a method has multiple separate C# attribute brackets (e.g. [HttpPost] + [Route(...)])

1 participant