This repository was archived by the owner on Mar 20, 2023. It is now read-only.
Enable auto checkpointing on SIGTERM - #546
Draft
ferdonline wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
I don't really understand why the CI could fail in GPU. @pramodk Ideas? |
alkino
reviewed
May 17, 2021
Comment on lines
+425
to
+427
| std::cerr << "SIGTERM caught! Halting sim and dumping checkpoint" << std::endl; | ||
| coreneuron::stoprun = true; | ||
| }; |
Member
There was a problem hiding this comment.
What is often do is to enable a "double sigterm", to really cut things
How long is this checkpoint can be?
Collaborator
sorry for delay - this issue is being investigated. You can ignore this error. |
Contributor
|
Can you rebase this @ferdonline? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
注册 for free
to subscribe to this conversation on GitHub.
Already have an account?
登录.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As a follow up to #252, we want CoreNeuron to be able to create checkpoints right before an allocation expires.
Since most job schedulers send a SIGTERM before sigkill, we implement a handler for such signal. It may, however, be needed to tune the time to sending this signal, since long simulations may take a bit of time to write everything out.
Implementation
Checkpoints are created in a folder
_corenrn_ckptinside the output root only if a minimum amount of time elapsed.This directory is checked for existence on startup if no
--restoreis provided.