Check if a trend can be resumed in SliceTrendingTask - #2682
Open
knopers8 wants to merge 1 commit into
Open
Conversation
Fixes QC-1300, where it was reported that a change in axisDivision of a resumed trend would cause a difficult to understand crash, with an STL exception only, but no stack trace leading to it. While std::exceptions (such as these thrown by STL) do not contain stacktraces, improvements may or may not come in the scope of QC-247.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
注册 for free
to join this conversation on GitHub.
Already have an account?
登录 to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes QC-1300, where it was reported that a change in axisDivision of a resumed trend would cause a difficult to understand crash, with an STL exception only, but no stack trace leading to it.
While std::exceptions (such as these thrown by STL) do not contain stacktraces, improvements may or may not come in the scope of QC-247.
canContinueTrendis based on a similar function in TrendingTask:QualityControl/Framework/src/TrendingTask.cxx
Line 56 in 6f2b91c