Skip to content

fix(editor): keep fullscreen controls above bottom pane tabs - #2834

Merged
bajrangCoder merged 1 commit into
mainfrom
fix-bottom-tabs-header-position
Aug 29, 2026
Merged

fix(editor): keep fullscreen controls above bottom pane tabs#2834
bajrangCoder merged 1 commit into
mainfrom
fix-bottom-tabs-header-position

Conversation

@bajrangCoder

Copy link
Copy Markdown
Member

Fixes: #2766

@greptile-apps

greptile-apps Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR keeps fullscreen navigation controls and their menus at the top when open-file tabs are positioned at the bottom.

  • Removes the special bottom anchoring for the main and file menus.
  • Removes fullscreen CSS that moved the header and sidebar control above bottom tabs and footer rows.

Confidence Score: 5/5

The PR appears safe to merge, with the menu anchors and fullscreen controls remaining consistently positioned at the top.

The removed special case previously moved both controls and menus to the bottom; the remaining styles and menu options now keep those related elements together at the top without affecting bottom tab or footer placement.

Important Files Changed

Filename Overview
src/main.js Makes both header menus consistently top-anchored, matching their togglers’ resulting fullscreen position.
src/styles/page.scss Removes bottom-position overrides so fullscreen controls use the existing top-positioned layout.

Reviews (1): Last reviewed commit: "fix(editor): keep fullscreen controls ab..." | Re-trigger Greptile

@bajrangCoder
bajrangCoder added this pull request to the merge queue Aug 29, 2026
Merged via the queue into main with commit eac9b6e Aug 29, 2026
9 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in The Code Board - Acode Aug 29, 2026
@bajrangCoder
bajrangCoder deleted the fix-bottom-tabs-header-position branch August 29, 2026 17:45
注册 for free to join this conversation on GitHub. Already have an account? 登录 to comment

标签

None yet

项目

Status: Done

Development

Successfully merging this pull request may close these issues.

Floating navigation bug

1 participant