Skip to content

fix(editor): stabilize selection menu sizing and transitions - #2833

Merged
bajrangCoder merged 1 commit into
mainfrom
fix-selection-menu-sizing
Aug 29, 2026
Merged

fix(editor): stabilize selection menu sizing and transitions#2833
bajrangCoder merged 1 commit into
mainfrom
fix-selection-menu-sizing

Conversation

@bajrangCoder

Copy link
Copy Markdown
Member

No description provided.

@greptile-apps

greptile-apps Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR stabilizes the touch-selection menu by deriving its dimensions from active content, resetting stale geometry, and coordinating primary/overflow transitions.

  • Adds explicit overflow expansion state and cancellation-safe animation cleanup.
  • Animates menu geometry and panel transitions from measured initial and final bounds.
  • Updates selection-menu CSS for intrinsic sizing, hidden-panel removal, and bounded overflow layouts.

Confidence Score: 5/5

The PR appears safe to merge; no concrete blocking or independently actionable non-blocking issue remains.

The revised transition cancellation, expansion-state synchronization, rerender cleanup, and overflow sizing remain internally consistent across opening, rapid reversal, rerender, and close paths.

Important Files Changed

Filename Overview
src/cm/touchSelectionMenu.js Reworks overflow transition state, geometry measurement, cancellation, and lifecycle cleanup without an identified actionable defect.
src/main.scss Replaces fixed menu sizing with content-driven dimensions and preserves bounded scrolling for overflow actions.

Reviews (1): Last reviewed commit: "fix(editor): stabilize selection menu si..." | Re-trigger Greptile

@bajrangCoder
bajrangCoder added this pull request to the merge queue Aug 29, 2026
Merged via the queue into main with commit febb4f7 Aug 29, 2026
9 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in The Code Board - Acode Aug 29, 2026
@bajrangCoder
bajrangCoder deleted the fix-selection-menu-sizing branch August 29, 2026 17:31
注册 for free to join this conversation on GitHub. Already have an account? 登录 to comment

标签

None yet

项目

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant