After microsoft/typescript-go#4867, realpath on macOS now preserves the caller casing when the input isn't a symlink. That exposes a watch bug. WatchManager's DirWatchSet contains lowercased paths (even though they're typed as string, not tspath.Path). Those lowercased paths are given to fswatch, which works, but FSEvents then reports back events using actual disk casing. fsevents uses case-insensitive comparison to determine whether to call its callback, so the events get dropped.
I handed this to Copilot and it immediately jumped to bringing back the pre-microsoft/typescript-go#4867 realpath behavior for directories specifically, since directories can't be hardlinks. I thought that was a really weird place to start, but technically it seems to fix the bug.
I think the more likely correct fix is either:
WatchManager should hold both the original file casing for passing to fswatch and lowercased casing for deduplication/comparisonfswatch should be doing case-insensitive matching on case-insensitive file systems
The latter seems like the most robust (I'm not sure if we can guarantee that the original file casing we see in tsc actually matches the disk in all cases; it seems possible that the casing of "include": ["SRC"] from a tsconfig will get preserved and we'll never be aware of the disk casing). But it also seems the most expensive and invasive, which is a bummer.
cc Jake Bailey (@jakebailey) John Favret (@johnfav03)
After microsoft/typescript-go#4867, realpath on macOS now preserves the caller casing when the input isn't a symlink. That exposes a watch bug.
WatchManager'sDirWatchSetcontains lowercased paths (even though they're typed asstring, nottspath.Path). Those lowercased paths are given tofswatch, which works, but FSEvents then reports back events using actual disk casing.fseventsuses case-insensitive comparison to determine whether to call its callback, so the events get dropped.I handed this to Copilot and it immediately jumped to bringing back the pre-microsoft/typescript-go#4867
realpathbehavior for directories specifically, since directories can't be hardlinks. I thought that was a really weird place to start, but technically it seems to fix the bug.I think the more likely correct fix is either:
WatchManagershould hold both the original file casing for passing tofswatchand lowercased casing for deduplication/comparisonfswatchshould be doing case-insensitive matching on case-insensitive file systemsThe latter seems like the most robust (I'm not sure if we can guarantee that the original file casing we see in
tscactually matches the disk in all cases; it seems possible that the casing of"include": ["SRC"]from a tsconfig will get preserved and we'll never be aware of the disk casing). But it also seems the most expensive and invasive, which is a bummer.cc Jake Bailey (@jakebailey) John Favret (@johnfav03)