Skip to content

CI Fix - Fabric CI Currently Failing #5970

Description

@cmgoffena13

Link: https://github.com/SQLMesh/sqlmesh/actions/runs/32525879293/job/96916106956

Two 问题 that are failing the Fabric Tests. These are code based.

AI Notes

1

Failing tests
tests/core/engine_adapter/integration/test_integration_fabric.py::test_create_drop_catalog
tests/core/engine_adapter/integration/test_integration.py::test_janitor[fabric-catalog]

What’s Wrong
Creating a Fabric warehouse that already exists should do nothing. Fabric used to return HTTP 400 for that; now it returns 409. Our code only handles 400, so it crashes.

Possible Fix
In sqlmesh/core/engine_adapter/fabric.py (create_warehouse): treat “already exists” (ItemDisplayNameAlreadyInUse) on 409 the same way as 400.

2

Failing tests
tests/core/engine_adapter/integration/test_integration.py::test_catalog_operations[fabric]
tests/core/engine_adapter/integration/test_integration.py::test_get_data_objects[[query]fabric]
tests/core/engine_adapter/integration/test_integration.py::test_get_data_objects[[df-pandas]fabric]

What’s Wrong
On Fabric, the default warehouse is stored as None. Other code expects a real name like ci_050fce7a, so .lower() crashes and get_data_objects returns objects with no catalog.

Possible Fix
In sqlmesh/core/engine_adapter/fabric.py: make get_current_catalog() return the real default DB name when you’re on default, instead of None.

Metadata

Metadata

标签

Type

No type

项目

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions